Browse Source

FILS: Check req_ies for NULL pointer in hostapd_notif_assoc()

Add checking for NULL req_ies when FILS processing a driver ASSOC event
in hostapd_notif_assoc(). This was already done in number of old code
paths, but the newer FILS path did not handle this. Though, it is
unlikely that this code path would be reachable in practice since this
is all within sta->auth_alg == WLAN_AUTH_FILS_* check.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Peng Xu 7 years ago
parent
commit
3de1566db8
1 changed files with 3 additions and 0 deletions
  1. 3 0
      src/ap/drv_callbacks.c

+ 3 - 0
src/ap/drv_callbacks.c

@@ -451,6 +451,9 @@ skip_wpa_check:
 	    sta->auth_alg == WLAN_AUTH_FILS_PK) {
 	    sta->auth_alg == WLAN_AUTH_FILS_PK) {
 		int delay_assoc = 0;
 		int delay_assoc = 0;
 
 
+		if (!req_ies)
+			return WLAN_STATUS_UNSPECIFIED_FAILURE;
+
 		if (!wpa_fils_validate_fils_session(sta->wpa_sm, req_ies,
 		if (!wpa_fils_validate_fils_session(sta->wpa_sm, req_ies,
 						    req_ies_len,
 						    req_ies_len,
 						    sta->fils_session)) {
 						    sta->fils_session)) {