Home Explore Help
Register Sign In
wareck
/
krackattacks
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

Remove [MU-BEAMFORMEE] option from hostapd vht_capab parameter

The standard hardcodes the MU Beamformee Capable subfield is hardcoded
to 0 when transmitting by an AP, so there is no need to provide a
configuration parameter for setting this to one.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Jouni Malinen 9 years ago
parent
c5ee4dd9d9
commit
ee120ff381
3 changed files with 1 additions and 8 deletions
Unified View Show Diff Stats
  1. 0 2
      hostapd/config_file.c
  2. 0 5
      hostapd/hostapd.conf
  3. 1 1
      tests/hwsim/test_ap_vht.py

+ 0 - 2
hostapd/config_file.c
View File 

@@ -1163,8 +1163,6 @@ static int hostapd_config_vht_capab(struct hostapd_config *conf,
 
 		conf->vht_capab |= (1 << VHT_CAP_SOUNDING_DIMENSION_OFFSET);
 
 		conf->vht_capab |= (1 << VHT_CAP_SOUNDING_DIMENSION_OFFSET);
 
 	if (os_strstr(capab, "[MU-BEAMFORMER]"))
 
 	if (os_strstr(capab, "[MU-BEAMFORMER]"))
 
 		conf->vht_capab |= VHT_CAP_MU_BEAMFORMER_CAPABLE;
 
 		conf->vht_capab |= VHT_CAP_MU_BEAMFORMER_CAPABLE;
 
-	if (os_strstr(capab, "[MU-BEAMFORMEE]"))
 
-		conf->vht_capab |= VHT_CAP_MU_BEAMFORMEE_CAPABLE;
 
 	if (os_strstr(capab, "[VHT-TXOP-PS]"))
 
 	if (os_strstr(capab, "[VHT-TXOP-PS]"))
 
 		conf->vht_capab |= VHT_CAP_VHT_TXOP_PS;
 
 		conf->vht_capab |= VHT_CAP_VHT_TXOP_PS;
 
 	if (os_strstr(capab, "[HTC-VHT]"))
 
 	if (os_strstr(capab, "[HTC-VHT]"))

+ 0 - 5
hostapd/hostapd.conf
View File 

@@ -598,11 +598,6 @@ wmm_ac_vo_acm=0
 
 # 0 = Not supported or sent by Non-AP STA (default)
 
 # 0 = Not supported or sent by Non-AP STA (default)
 
 # 1 = Supported
 
 # 1 = Supported
 
 #
 
 #
 
-# MU Beamformee Capable: [MU-BEAMFORMEE]
 
-# Indicates support for operation as an MU beamformee
 
-# 0 = Not supported or sent by AP (default)
 
-# 1 = Supported
 
-#
 
 # VHT TXOP PS: [VHT-TXOP-PS]
 
 # VHT TXOP PS: [VHT-TXOP-PS]
 
 # Indicates whether or not the AP supports VHT TXOP Power Save Mode
 
 # Indicates whether or not the AP supports VHT TXOP Power Save Mode
 
 #  or whether or not the STA is in VHT TXOP Power Save mode
 
 #  or whether or not the STA is in VHT TXOP Power Save mode

+ 1 - 1
tests/hwsim/test_ap_vht.py
View File 

@@ -164,7 +164,7 @@ def test_ap_vht_capab_not_supported(dev, apdev):
 
                    "ieee80211n": "1",
 
                    "ieee80211n": "1",
 
                    "ieee80211ac": "1",
 
                    "ieee80211ac": "1",
 
                    "vht_oper_chwidth": "1",
 
                    "vht_oper_chwidth": "1",
 
-                   "vht_capab": "[MAX-MPDU-7991][MAX-MPDU-11454][VHT160][VHT160-80PLUS80][RXLDPC][SHORT-GI-80][SHORT-GI-160][TX-STBC-2BY1][RX-STBC-1][RX-STBC-12][RX-STBC-123][RX-STBC-1234][SU-BEAMFORMER][SU-BEAMFORMEE][BF-ANTENNA-2][SOUNDING-DIMENSION-2][MU-BEAMFORMER][MU-BEAMFORMEE][VHT-TXOP-PS][HTC-VHT][MAX-A-MPDU-LEN-EXP0][MAX-A-MPDU-LEN-EXP7][VHT-LINK-ADAPT2][VHT-LINK-ADAPT3][RX-ANTENNA-PATTERN][TX-ANTENNA-PATTERN]",
 
+                   "vht_capab": "[MAX-MPDU-7991][MAX-MPDU-11454][VHT160][VHT160-80PLUS80][RXLDPC][SHORT-GI-80][SHORT-GI-160][TX-STBC-2BY1][RX-STBC-1][RX-STBC-12][RX-STBC-123][RX-STBC-1234][SU-BEAMFORMER][SU-BEAMFORMEE][BF-ANTENNA-2][SOUNDING-DIMENSION-2][MU-BEAMFORMER][VHT-TXOP-PS][HTC-VHT][MAX-A-MPDU-LEN-EXP0][MAX-A-MPDU-LEN-EXP7][VHT-LINK-ADAPT2][VHT-LINK-ADAPT3][RX-ANTENNA-PATTERN][TX-ANTENNA-PATTERN]",
 
                    "vht_oper_centr_freq_seg0_idx": "42",
 
                    "vht_oper_centr_freq_seg0_idx": "42",
 
                    "require_vht": "1" }
 
                    "require_vht": "1" }
 
         hapd = hostapd.add_ap(apdev[0]['ifname'], params, wait_enabled=False)
 
         hapd = hostapd.add_ap(apdev[0]['ifname'], params, wait_enabled=False)