182-USB-bcma-use-devm_kzalloc.patch 1.5 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647
  1. From 93724affb195149df6f7630901d878f6e273fa02 Mon Sep 17 00:00:00 2001
  2. From: Hauke Mehrtens <hauke@hauke-m.de>
  3. Date: Thu, 11 Jun 2015 22:57:37 +0200
  4. Subject: [PATCH] USB: bcma: use devm_kzalloc
  5. Instead of manually handling the frees use devm. There was also a free
  6. missing in the unregister call which is not needed with devm.
  7. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
  8. ---
  9. drivers/usb/host/bcma-hcd.c | 11 ++++-------
  10. 1 file changed, 4 insertions(+), 7 deletions(-)
  11. --- a/drivers/usb/host/bcma-hcd.c
  12. +++ b/drivers/usb/host/bcma-hcd.c
  13. @@ -225,7 +225,8 @@ static int bcma_hcd_probe(struct bcma_de
  14. if (dma_set_mask_and_coherent(dev->dma_dev, DMA_BIT_MASK(32)))
  15. return -EOPNOTSUPP;
  16. - usb_dev = kzalloc(sizeof(struct bcma_hcd_device), GFP_KERNEL);
  17. + usb_dev = devm_kzalloc(&dev->dev, sizeof(struct bcma_hcd_device),
  18. + GFP_KERNEL);
  19. if (!usb_dev)
  20. return -ENOMEM;
  21. @@ -239,10 +240,8 @@ static int bcma_hcd_probe(struct bcma_de
  22. ohci_addr = 0x18009000;
  23. usb_dev->ohci_dev = bcma_hcd_create_pdev(dev, true, ohci_addr);
  24. - if (IS_ERR(usb_dev->ohci_dev)) {
  25. - err = PTR_ERR(usb_dev->ohci_dev);
  26. - goto err_free_usb_dev;
  27. - }
  28. + if (IS_ERR(usb_dev->ohci_dev))
  29. + return PTR_ERR(usb_dev->ohci_dev);
  30. usb_dev->ehci_dev = bcma_hcd_create_pdev(dev, false, dev->addr);
  31. if (IS_ERR(usb_dev->ehci_dev)) {
  32. @@ -255,8 +254,6 @@ static int bcma_hcd_probe(struct bcma_de
  33. err_unregister_ohci_dev:
  34. platform_device_unregister(usb_dev->ohci_dev);
  35. -err_free_usb_dev:
  36. - kfree(usb_dev);
  37. return err;
  38. }