0249-bcm2835-do-not-require-substream-for-accessing-chmap.patch 1.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051
  1. From 367f4ce11d5588d680ae50c405b1a9afa591a550 Mon Sep 17 00:00:00 2001
  2. From: wm4 <wm4@nowhere>
  3. Date: Tue, 19 Apr 2016 16:08:35 +0200
  4. Subject: [PATCH 249/381] bcm2835: do not require substream for accessing chmap
  5. ctl
  6. Fixes alsasctl store/restore operation.
  7. ---
  8. sound/arm/bcm2835-ctl.c | 10 +---------
  9. 1 file changed, 1 insertion(+), 9 deletions(-)
  10. --- a/sound/arm/bcm2835-ctl.c
  11. +++ b/sound/arm/bcm2835-ctl.c
  12. @@ -489,8 +489,6 @@ static int snd_bcm2835_chmap_ctl_get(str
  13. {
  14. struct snd_pcm_chmap *info = snd_kcontrol_chip(kcontrol);
  15. bcm2835_chip_t *chip = info->private_data;
  16. - unsigned int idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
  17. - struct snd_pcm_substream *substream = snd_pcm_chmap_substream(info, idx);
  18. struct cea_channel_speaker_allocation *ch = NULL;
  19. int res = 0;
  20. int cur = 0;
  21. @@ -499,11 +497,6 @@ static int snd_bcm2835_chmap_ctl_get(str
  22. if (mutex_lock_interruptible(&chip->audio_mutex))
  23. return -EINTR;
  24. - if (!substream || !substream->runtime) {
  25. - res = -ENODEV;
  26. - goto unlock;
  27. - }
  28. -
  29. for (i = 0; i < ARRAY_SIZE(channel_allocations); i++) {
  30. if (channel_allocations[i].ca_index == chip->cea_chmap)
  31. ch = &channel_allocations[i];
  32. @@ -521,7 +514,6 @@ static int snd_bcm2835_chmap_ctl_get(str
  33. while (cur < 8)
  34. ucontrol->value.integer.value[cur++] = SNDRV_CHMAP_NA;
  35. -unlock:
  36. mutex_unlock(&chip->audio_mutex);
  37. return res;
  38. }
  39. @@ -541,7 +533,7 @@ static int snd_bcm2835_chmap_ctl_put(str
  40. return -EINTR;
  41. if (!substream || !substream->runtime) {
  42. - res = -ENODEV;
  43. + /* ignore and return success for the sake of alsactl */
  44. goto unlock;
  45. }