0088-net-next-mediatek-fix-threshold-value.patch 1.2 KB

123456789101112131415161718192021222324252627282930
  1. From 34ea0f209e0759158e363039852a04b1facc3acd Mon Sep 17 00:00:00 2001
  2. From: John Crispin <john@phrozen.org>
  3. Date: Tue, 3 May 2016 02:55:27 +0200
  4. Subject: [PATCH 088/102] net-next: mediatek: fix threshold value
  5. MIME-Version: 1.0
  6. Content-Type: text/plain; charset=UTF-8
  7. Content-Transfer-Encoding: 8bit
  8. The logic to calculate the threshold value for stopping the TX queue is
  9. bad. Currently it will always use 1/2 of the rings size, which is way too
  10. much. Set the threshold to MAX_SKB_FRAGS. This makes sure that the queue
  11. is stopped when there is not enough room to accept an additional segment. 
  12. Signed-off-by: John Crispin <john@phrozen.org>
  13. ---
  14. drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 +--
  15. 1 file changed, 1 insertion(+), 2 deletions(-)
  16. --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
  17. +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
  18. @@ -1043,8 +1043,7 @@ static int mtk_tx_alloc(struct mtk_eth *
  19. atomic_set(&ring->free_count, MTK_DMA_SIZE - 2);
  20. ring->next_free = &ring->dma[0];
  21. ring->last_free = &ring->dma[MTK_DMA_SIZE - 2];
  22. - ring->thresh = max((unsigned long)MTK_DMA_SIZE >> 2,
  23. - MAX_SKB_FRAGS);
  24. + ring->thresh = MAX_SKB_FRAGS;
  25. /* make sure that all changes to the dma ring are flushed before we
  26. * continue