Home Explore Help
Register Sign In
wareck
/
openwrt-archive
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Branch: master
Branches Tags
openwrt-archive
/
target
/
linux
/
ipq806x
/
patches-4.4
/
161-mtd-nand-Create-a-BBT-flag-to-access-bad-block-markers-in-raw-mode.patch

161-mtd-nand-Create-a-BBT-flag-to-access-bad-block-markers-in-raw-mode.patch 2.8 KB
Permalink History Raw

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283 
  1. Content-Type: text/plain; charset="utf-8"
    2. 

  2. MIME-Version: 1.0
    3. 

  3. Content-Transfer-Encoding: 7bit
    4. 

  4. Subject: [v3,
    5. 

  5. 	1/5] mtd: nand: Create a BBT flag to access bad block markers in raw
    6. 

  6. 	mode
    7. 

  7. From: Archit Taneja <architt@codeaurora.org>
    8. 

  8. X-Patchwork-Id: 6927081
    9. 

  9. Message-Id: <1438578498-32254-2-git-send-email-architt@codeaurora.org>
    10. 

  10. To: linux-mtd@lists.infradead.org, dehrenberg@google.com,
    11. 

  11. 	cernekee@gmail.com, computersforpeace@gmail.com
    12. 

  12. Cc: linux-arm-msm@vger.kernel.org, agross@codeaurora.org,
    13. 

  13. 	sboyd@codeaurora.org, linux-kernel@vger.kernel.org,
    14. 

  14. 	Archit Taneja <architt@codeaurora.org>
    15. 

  15. Date: Mon,  3 Aug 2015 10:38:14 +0530
    16. 

  16. 

  17. Some controllers can access the factory bad block marker from OOB only
    18. 

  18. when they read it in raw mode. When ECC is enabled, these controllers
    19. 

  19. discard reading/writing bad block markers, preventing access to them
    20. 

  20. altogether.
    21. 

  21. 

  22. The bbt driver assumes MTD_OPS_PLACE_OOB when scanning for bad blocks.
    23. 

  23. This results in the nand driver's ecc->read_oob() op to be called, which
    24. 

  24. works with ECC enabled.
    25. 

  25. 

  26. Create a new BBT option flag that tells nand_bbt to force the mode to
    27. 

  27. MTD_OPS_RAW. This would result in the correct op being called for the
    28. 

  28. underlying nand controller driver.
    29. 

  29. 

  30. Reviewed-by: Andy Gross <agross@codeaurora.org>
    31. 

  31. Signed-off-by: Archit Taneja <architt@codeaurora.org>
    32. 

  32. 

  33. ---
    34. 

  34. drivers/mtd/nand/nand_base.c | 6 +++++-
    35. 

  35.  drivers/mtd/nand/nand_bbt.c  | 6 +++++-
    36. 

  36.  include/linux/mtd/bbm.h      | 7 +++++++
    37. 

  37.  3 files changed, 17 insertions(+), 2 deletions(-)
    38. 

  38. 

  39. --- a/drivers/mtd/nand/nand_base.c
    40. 

  40. +++ b/drivers/mtd/nand/nand_base.c
    41. 

  41. @@ -394,7 +394,11 @@ static int nand_default_block_markbad(st
    42. 

  42.  	} else {
    43. 

  43.  		ops.len = ops.ooblen = 1;
    44. 

  44.  	}
    45. 

  45. -	ops.mode = MTD_OPS_PLACE_OOB;
    46. 

  46. +
    47. 

  47. +	if (unlikely(chip->bbt_options & NAND_BBT_ACCESS_BBM_RAW))
    48. 

  48. +		ops.mode = MTD_OPS_RAW;
    49. 

  49. +	else
    50. 

  50. +		ops.mode = MTD_OPS_PLACE_OOB;
    51. 

  51.  
    52. 

  52.  	/* Write to first/last page(s) if necessary */
    53. 

  53.  	if (chip->bbt_options & NAND_BBT_SCANLASTPAGE)
    54. 

  54. --- a/drivers/mtd/nand/nand_bbt.c
    55. 

  55. +++ b/drivers/mtd/nand/nand_bbt.c
    56. 

  56. @@ -420,7 +420,11 @@ static int scan_block_fast(struct mtd_in
    57. 

  57.  	ops.oobbuf = buf;
    58. 

  58.  	ops.ooboffs = 0;
    59. 

  59.  	ops.datbuf = NULL;
    60. 

  60. -	ops.mode = MTD_OPS_PLACE_OOB;
    61. 

  61. +
    62. 

  62. +	if (unlikely(bd->options & NAND_BBT_ACCESS_BBM_RAW))
    63. 

  63. +		ops.mode = MTD_OPS_RAW;
    64. 

  64. +	else
    65. 

  65. +		ops.mode = MTD_OPS_PLACE_OOB;
    66. 

  66.  
    67. 

  67.  	for (j = 0; j < numpages; j++) {
    68. 

  68.  		/*
    69. 

  69. --- a/include/linux/mtd/bbm.h
    70. 

  70. +++ b/include/linux/mtd/bbm.h
    71. 

  71. @@ -116,6 +116,12 @@ struct nand_bbt_descr {
    72. 

  72.  #define NAND_BBT_NO_OOB_BBM	0x00080000
    73. 

  73.  
    74. 

  74.  /*
    75. 

  75. + * Force MTD_OPS_RAW mode when trying to access bad block markes from OOB. To
    76. 

  76. + * be used by controllers which can access BBM only when ECC is disabled, i.e,
    77. 

  77. + * when in RAW access mode
    78. 

  78. + */
    79. 

  79. +#define NAND_BBT_ACCESS_BBM_RAW        0x00100000
    80. 

  80. +/*
    81. 

  81.   * Flag set by nand_create_default_bbt_descr(), marking that the nand_bbt_descr
    82. 

  82.   * was allocated dynamicaly and must be freed in nand_release(). Has no meaning
    83. 

  83.   * in nand_chip.bbt_options.
    84.