351-0044-brcmfmac-remove-unnecessary-null-pointer-check.patch 1.2 KB

12345678910111213141516171819202122232425262728293031
  1. From 835680b82f029818c813324aed3073cdcf63241f Mon Sep 17 00:00:00 2001
  2. From: Hante Meuleman <hante.meuleman@broadcom.com>
  3. Date: Mon, 19 Sep 2016 12:09:56 +0100
  4. Subject: [PATCH] brcmfmac: remove unnecessary null pointer check
  5. in the function brcmf_bus_start() in the exception handling a
  6. check is made to dermine whether ifp is null, though this is not
  7. possible. Removing the unnessary check.
  8. Reviewed-by: Arend Van Spriel <arend.vanspriel@broadcom.com>
  9. Reviewed-by: Franky Lin <franky.lin@broadcom.com>
  10. Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
  11. Signed-off-by: Hante Meuleman <hante.meuleman@broadcom.com>
  12. Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
  13. Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  14. ---
  15. drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 +--
  16. 1 file changed, 1 insertion(+), 2 deletions(-)
  17. --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
  18. +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
  19. @@ -1048,8 +1048,7 @@ fail:
  20. brcmf_fws_del_interface(ifp);
  21. brcmf_fws_deinit(drvr);
  22. }
  23. - if (ifp)
  24. - brcmf_net_detach(ifp->ndev, false);
  25. + brcmf_net_detach(ifp->ndev, false);
  26. if (p2p_ifp)
  27. brcmf_net_detach(p2p_ifp->ndev, false);
  28. drvr->iflist[0] = NULL;