1234567891011121314151617181920212223242526272829303132333435363738 |
- From e3b1d879ccda9ffd5332777bb1beeb2cc913faa8 Mon Sep 17 00:00:00 2001
- From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
- Date: Sun, 21 Jul 2019 21:52:17 +0200
- Subject: [PATCH] brcmfmac: don't net_ratelimit() CONSOLE messages on firmware
- crash
- MIME-Version: 1.0
- Content-Type: text/plain; charset=UTF-8
- Content-Transfer-Encoding: 8bit
- Firmware crash is a pretty rare event and can't happen too frequently as
- it has to be followed by a hardware reinitialization and config reload.
- It should be safe to don't use net_ratelimit() when it happens.
- For reporting & debugging purposes it's important to provide a complete
- log as the last lines are actually the most important. This change
- modifies brcmfmac to print all messages in an unlimited way in that
- specific case. With this change there should be finally a backtrace of
- firmware finally visible after a crash.
- Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
- Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
- Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
- ---
- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
- --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
- +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
- @@ -800,7 +800,8 @@ static void brcmf_pcie_bus_console_read(
- if (ch == '\n') {
- console->log_str[console->log_idx] = 0;
- if (error)
- - brcmf_err(bus, "CONSOLE: %s", console->log_str);
- + __brcmf_err(bus, __func__, "CONSOLE: %s",
- + console->log_str);
- else
- pr_debug("CONSOLE: %s", console->log_str);
- console->log_idx = 0;
|