| 1234567891011121314151617181920212223242526 |
- From bbfab331e3abd9fa8767eea6bf5c4684cdd4b934 Mon Sep 17 00:00:00 2001
- From: Neo Jou <neojou@gmail.com>
- Date: Tue, 21 May 2019 17:12:20 +0800
- Subject: [PATCH] brcmfmac: use strlcpy() instead of strcpy()
- The function strcpy() is inherently not safe. Though the function
- works without problems here, it would be better to use other safer
- function, e.g. strlcpy(), to replace strcpy() still.
- Signed-off-by: Neo Jou <neojou@gmail.com>
- Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
- ---
- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
- --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
- +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
- @@ -157,7 +157,7 @@ int brcmf_c_preinit_dcmds(struct brcmf_i
-
- /* query for 'ver' to get version info from firmware */
- memset(buf, 0, sizeof(buf));
- - strcpy(buf, "ver");
- + strlcpy(buf, "ver", sizeof(buf));
- err = brcmf_fil_iovar_data_get(ifp, "ver", buf, sizeof(buf));
- if (err < 0) {
- bphy_err(drvr, "Retrieving version information failed, %d\n",
|
