| 1234567891011121314151617181920212223242526272829303132333435363738 |
- From c33330ac06fe863289643e7a13ecdb6a2502dad7 Mon Sep 17 00:00:00 2001
- From: Arend van Spriel <arend.vanspriel@broadcom.com>
- Date: Thu, 11 Jul 2019 11:05:09 +0200
- Subject: [PATCH] brcmfmac: clear events in brcmf_fweh_detach() will always
- fail
- Clearing firmware events in brcmf_fweh_detach() is always failing
- because it is called only upon driver remove and communication
- with firmware is no longer possible.
- Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
- Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
- Reviewed-by: Franky Lin <franky.lin@broadcom.com>
- Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
- Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
- ---
- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 9 ---------
- 1 file changed, 9 deletions(-)
- --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
- +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
- @@ -319,16 +319,7 @@ void brcmf_fweh_attach(struct brcmf_pub
- void brcmf_fweh_detach(struct brcmf_pub *drvr)
- {
- struct brcmf_fweh_info *fweh = &drvr->fweh;
- - struct brcmf_if *ifp = brcmf_get_ifp(drvr, 0);
- - s8 eventmask[BRCMF_EVENTING_MASK_LEN];
-
- - if (ifp) {
- - /* clear all events */
- - memset(eventmask, 0, BRCMF_EVENTING_MASK_LEN);
- - (void)brcmf_fil_iovar_data_set(ifp, "event_msgs",
- - eventmask,
- - BRCMF_EVENTING_MASK_LEN);
- - }
- /* cancel the worker */
- cancel_work_sync(&fweh->event_work);
- WARN_ON(!list_empty(&fweh->event_q));
|
